Allow multiline suggestions in map-unwrap-or
#16114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
Lintcheck changes for d707ec1
This comment will be updated if you push new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently got a
map-unwrap-orwarning with no suggestion, and was very confused because I couldn't tell what the lint was flagging.It turned out the "else" part had multiple lines, so the lint decided not to include a suggestion.
Please look at this PR's stderr file, and decide whether you like it. Then look at its predecessor, and decide whether you like it.
IMHO, the one with the suggestions is much more informative, even if not as pretty.
changelog: Allow multiline suggestions in
map-unwrap-or